letsencrypt
/
ct-woodpecker
/
455
69%
main: 68%
main: 68%
|
Ran
|
Jobs
1
|
Files
12
|
Run time
3s
|
Badge
Embed ▾
README BADGES
|
coverage: 67.193%. Remained the same
cron
travis-ci
jshaFix golangci nits (#68) This PR addresses the low hanging nits [flagged by GolangCI](https://golangci.com/r/github.com/letsencrypt/ct-woodpecker). It leaves three "megacheck" findings yet to be addressed in the `cttestsrv`: * signedLogRoot.TreeSize is deprecated: TreeSize moved to LogRoot. * signedLogRoot.TimestampNanos is deprecated: TimestampNanos moved to LogRoot. * signedLogRoot.RootHash is deprecated: RootHash moved to LogRoot. All of the above are a result of https://github.com/google/trillian/commit/0c12c8487 - it looks like the `certificate-transparency-go` ctfe is still using the deprecated fields so I think we can ignore these for now. I _think_ fixing it will require unserializing the `log_root []byte` from the response and that's too fiddly for my low-hanging PR.
3 of 3 new or added lines in 2 files covered. (100.0%)
766 of 1140 relevant lines covered (67.19%)
4.38 hits per line
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 7 |
67.39 |
0.0% | monitor/cert_submitter.go |
| 8 |
50.89 |
0.0% | storage/storage.go |
| 12 |
71.29 |
0.0% | woodpecker/woodpecker.go |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 455.1 | 12 |
67.19 |
Travis Job 455.1 |
