skeema / tengo / 104

91%

main: 94%

push

travis-ci

ModifyColumn.Unsafe(): Whitelist more safe type changes

Previously, the following column type changes were unnecessarily marked as
unsafe:

* char(x) -> varchar(y), y >= x
* varchar(x) -> char(y), y >= x
* char(x) -> *text, where new text type max >= x
* varchar(x) -> *text, where new text type max >= x
* *text -> char(x), where x >= old text type max
* *text -> varchar(x), where x >= old text type max
* varbinary(x) -> *blob, where new blob type max >= x
* *blob -> varbinary(x), where x >= old blob type max
* bit(x) -> bit(y), y >= x
* *int unsigned -> *int, where new int type is strictly larger than old int
  type
* removing unsigned attribute from a float, decimal, or double (without
  otherwise reducing size)

All of these cases have no possibility of data loss, so they are now correctly
considered safe changes.

58 of 58 new or added lines in 1 file covered. (100.0%)

2070 of 2272 relevant lines covered (91.11%)

163.39 hits per line