14761
83%
master: 87%

Ran 10 Dec 2018 03:10PM UTC

Jobs 1

Files 362

Run time 2min

Badge

Embed ▾

pending completion

Build # 14761

Build Type

push

travis-ci

Committed by

sergepetrenko

Commit Message

replication: do not skip master's rows in case of an error

Applier used to promote vclock prior to applying the row. This lead to a
situation when master's row would be skipped forever in case there is an
error trying to apply it. However, some errors are transient, and we
might be able to successfully apply the same row later.

So only advance vclock if a corresponding row is successfully written to
WAL. This makes sure that rows are not skipped.
replication_skip_conflict works as before: if it is set an a conflict
occurs while applying the row, it is silently ignored and the vclock is
advanced, so the row is never applied.

While we're at it, make wal writer the only one responsible for
advancing replicaset vclock. It was already doing it for rows coming from
the local instance, besides, it makes the code cleaner since now we want
to advance vclock only after a successful write and lets us get rid of
unnecessary checks whether applier or wal has already advanced the
vclock.

Closes #2283

Run Details

63837 of 77416 relevant lines covered (82.46%)

2519866.24 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	14761.5 (TARGET=coverage)	10 Dec 2018 03:10PM UTC	362	82.46	Travis Job 14761.5

tarantool / tarantool / 14761
83%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14761

tarantool / tarantool / 14761 83% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14761

tarantool / tarantool / 14761
83%
master: 87%

README BADGES
x