source-academy / js-slang / 439

77%

push

travis-ci

Make || and && shorthand for ?: and improve TCO (#144)

* Implement LogicalExpression in terms of IfStatement

* Implement TCO for calls hidden inside ||, &&, and ?:

* Add test cases for TCO

* Use parseError on context.errors and use toEqual([]) instead of snapshot

* Use better test case for testing Infinite recursion error

* Remove ArrowClosure which fixes another TCO bug

Arrow closures could not be TCO'd before as `apply` didn't handle it
correctly. Instead of making a bunch of changes to make `apply` work I
decided to simply make all `ArrowFunctionExpresion` evaluate to `Closure`
instead of `ArrowClosure`.

This causes some of the test cases to fail, but they should've failed
from the beginning as they were all demonstrating iterative processes.

* Fix representation of functions in infinite recursion error message

* Fix regex for infinite recursion error message

The problem was that the very last call could potentially be the
function call in the argument (or not), so the regex has to match for
either i or r.

* Add test cases for mutual recursion, arrow and block arrow functions

344 of 470 branches covered (73.19%)

Branch coverage included in aggregate %.

1139 of 1444 relevant lines covered (78.88%)

10517.31 hits per line