4778
94%

Ran 08 Dec 2018 08:22AM UTC

Jobs 1

Files 88

Run time 59min

Badge

Embed ▾

pending completion

Build # 4778

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Make UserPrefs truly a part of Model (#932)

Fix the codebase such that UserPrefs is truly a model component, and any
other code accessing user preferences will need to go through the Model
interface.

  [1/15] UserPrefs: rename updateLastUsedGuiSetting(...) to setGuiSettings(...)
  [2/15] GuiSettings: use `double` instead of `Double`
  [3/15] GuiSettings: make deeply immutable
  [4/15] GuiSettings#equals(...): fix NPE when windowCoordinates is null
  [5/15] UserPrefs: use default GuiSettings values
  [6/15] UserPrefs: remove setGuiSettings(double, double, int, int)
  [7/15] UserPrefs: make guiSettings non-nullable
  [8/15] UserPrefs: enforce addressBookFilePath non-nullable invariant
  [9/15] UserPrefs#toString(): remove unnecessary toString() call
  [10/15] Model: rename resetData(...) to setAddressBook(...)
  [11/15] model: introduce ReadOnlyUserPrefs
  [12/15] model: make UserPrefs part of model state
  [13/15] ui: only access UserPrefs through logic
  [14/15] MainApp: only access UserPrefs via the model
  [15/15] ModelManager: keep its own copy of UserPrefs

Run Details

1415 of 1517 relevant lines covered (93.28%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4778.1	08 Dec 2018 08:22AM UTC	0	93.28	Travis Job 4778.1

Source Files on build 4778

Detailed source file information is not available for this build.

se-edu / addressbook-level4 / 4778
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4778

se-edu / addressbook-level4 / 4778 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4778

se-edu / addressbook-level4 / 4778
94%

README BADGES
x