9914
66%

Ran 07 Dec 2018 08:15PM UTC

Jobs 2

Files 88

Run time 765min

Badge

Embed ▾

Committed 07 Dec 2018 07:58PM UTC coverage: 63.052% (+0.06%) from 62.995%

Build # 9914

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

VA: Replace invalid UTF-8 in cert contents, proactively marshal. (#3973)

Marshaling invalid UTF-8 strings to protocol buffers causes an error. This can
happen in VA `PerformValidation` RPC responses if remote servers return invalid
UTF-8 in some ACME challenge contexts. We previously fixed this for HTTP-01 and
DNS-01 but missed a case where TLS-ALPN-01/TLS-SNI-01 challenge response
certificate content was included in error messages without replacing invalid
UTF-8. That's now fixed & unit tests are added.

To aid in diagnosing any future instances the VA is also updated to proactively
attempt to marshal its `PerformValidation` results before handing off to the RPC
wrappers that will do the same. This way if we detect an error in marshaling the
VA can audit log the escaped content for investigation purposes.

Hopefully with these two efforts combined we can avoid any future VA RPC errors
from UTF-8 encoding.

Resolves https://github.com/letsencrypt/boulder/issues/3838

Run Details

10816 of 17154 relevant lines covered (63.05%)

1.4 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
11	9914.11 (RUN="coverage" CONTAINER="netaccess")	07 Dec 2018 08:18PM UTC	0	63.05	Travis Job 9914.11
12	9914.12 (RUN="coverage" CONTAINER="netaccess")	07 Dec 2018 08:15PM UTC	0	63.05	Travis Job 9914.12

Source Files on build 9914

Detailed source file information is not available for this build.

letsencrypt / boulder / 9914
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9914

letsencrypt / boulder / 9914 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9914

letsencrypt / boulder / 9914
66%

README BADGES
x