gambol99 / go-marathon / 644

71%

master: 69%

Pull #163

travis-ci

Signal goroutine termination on event listener removal.

Fixes goroutine/memory leakage where an event consumer would stop
receiving events from the channel while pending goroutines were still
trying to deliver some.

The chosen approach only makes sense with unbuffered channels due to the
`select` involved; as such, we change AddEventListener's signature to
return a channel to the consumer instead of expecting one. Passing
buffered channels to AddEventListener was never overly useful in the
first place, however, as we use goroutines to avoid blocking on slow
receivers, implictly doing event buffering this way already.

Changes in detail:

- Modify AddEventListener's signature.
- Change listener's value type to struct holding both filters and a
  per-listener done channel.
- Close done channel on RemoveEventListener, and select between outbound
  and done channel in event-processing goroutine.
- Extend tests.
- Make existing tests more robust.
- Update examples.
- Update README file.

18 of 83 branches covered (21.69%)

390 of 551 relevant lines covered (70.78%)

0.71 hits per line