zulip / zulip-mobile / 7637

47%

push

travis-ci

settings: Refactor SettingsChangeAction to enable better typing.

The reducer didn't seem to be effectively type-checked; Flow
cheerfully accepted it even though it could have been setting any
property to any of `string` or `boolean`, even though none of them
accept that full range of possible values.

Instead, revise the actual actions to a more explicit style that makes
very natural JS code, and that enables Flow to see what's going on.
Now even calling `settingsChange` with a `theme` value of anything
other than the two permitted theme names will give an error, as it
should.

1399 of 2932 branches covered (47.71%)

Branch coverage included in aggregate %.

4812 of 6604 relevant lines covered (72.86%)

50.41 hits per line