OCA / account-financial-reporting / 2048

77%

9.0: 89%

Pull #491

travis-ci

[FIX] account_financial_report_webkit: Fix error if column exists

The code comments say this should be happening before, but it was actually failing with:

    2018-12-03 11:31:49,074 48 ERROR test openerp.sql_db: Programming error: column "last_rec_date" of relation "account_move_line" already exists
    , in query alter table account_move_line add column last_rec_date date
    2018-12-03 11:31:49,074 48 CRITICAL test openerp.service.server: Failed to initialize database `test`.
    Traceback (most recent call last):
    File "/opt/odoo/custom/src/odoo/openerp/service/server.py", line 941, in preload_registries
        registry = RegistryManager.new(dbname, update_module=update_module)
    File "/opt/odoo/custom/src/odoo/openerp/modules/registry.py", line 370, in new
        openerp.modules.load_modules(registry._db, force_demo, status, update_module)
    File "/opt/odoo/custom/src/odoo/openerp/modules/loading.py", line 354, in load_modules
        loaded_modules, update_module)
    File "/opt/odoo/custom/src/odoo/openerp/modules/loading.py", line 255, in load_marked_modules
        loaded, processed = load_module_graph(cr, graph, progressdict, report=report, skip_modules=loaded_modules, perform_checks=perform_checks)
    File "/opt/odoo/custom/src/odoo/openerp/modules/loading.py", line 150, in load_module_graph
        getattr(py_module, pre_init)(cr)
    File "/opt/odoo/auto/addons/account_financial_report_webkit/hooks.py", line 11, in pre_init_hook
        'alter table account_move_line add column last_rec_date date',
    File "/opt/odoo/custom/src/odoo/openerp/sql_db.py", line 171, in wrapper
        return f(self, *args, **kwargs)
    File "/opt/odoo/custom/src/odoo/openerp/sql_db.py", line 247, in execute
        res = self._obj.execute(query, params)
    ProgrammingError: column "last_rec_date" of relation "account_move_line" already exists

8 of 8 new or added lines in 1 file covered. (100.0%)

3083 of 3985 relevant lines covered (77.37%)

1.55 hits per line