codevise / pageflow / 2552
99%
master: 99%

LAST BUILD BRANCH: fix-before-after-dimensions
DEFAULT BRANCH: master
Ran
Jobs 2
Files 419
Run time 59min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2552

Pull #1076

travis-ci

web-flow 
Add path validation to HostedFile

To prevent malicious file names which could potentially overwrite other files on S3.
While at it I changed all occurrences of attachment_on_s3_file_name in specs to file_name, the aliased attribute name,
just in case we ever want to refactor the column name again.
Pull Request #1076: direct uploads

248 of 256 new or added lines in 28 files covered. (96.88%)

2 existing lines in 2 files now uncovered.

15484 of 15598 relevant lines covered (99.27%)

55.29 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
87.5
 -12.5% app/jobs/pageflow/process_file_job.rb
1
97.78
 -2.22% app/models/concerns/pageflow/hosted_file.rb
1
96.0
 4.33% app/models/pageflow/image_file.rb
5
92.96
 -7.04% app/controllers/pageflow/editor/files_controller.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
90.91
 -9.09% spec/support/config/paperclip.rb
1
87.5
 -12.5% app/jobs/pageflow/process_file_job.rb
Jobs
ID Job ID Ran Files Coverage
1 2552.1 (2.3.1, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true) 419
99.25
 Travis Job 2552.1
2 2552.2 (2.5.3, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true) 419
99.25
 Travis Job 2552.2
Source Files on build 2552