4756
94%

Ran 02 Dec 2018 08:01AM UTC

Jobs 1

Files 90

Run time 4s

Badge

Embed ▾

pending completion

Build # 4756

Build Type

push

travis-ci

Committed by

pyokagan

Commit Message

Model: rename updatePerson(...) to setPerson(...)

The method name `updatePerson` is a holdover from the time when Person
was mutable, and this method worked by directly modifying the target
person.

However, in a5cb7900 (UniquePersonList: Simplify logic of
updatePerson(...), 2017-08-05), the behavior was changed such that the
target person was not directly modified, but rather _replaced_ with a
new Person with the modified details.

Following that, in b2eeb18b (Person: Make immutable, 2017-12-20), Person
was made immutable.

So, now it doesn't make sense to say that we "update" the target person.

As such, let's rename updatePerson(...) to setPerson(...), which is a
better description of what the method does. This also makes the naming
consistent with AddressBook#setPerson(...) and
UniquePersonList#setPerson(...), which all do the same thing.

Run Details

1433 of 1544 relevant lines covered (92.81%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4756.1	02 Dec 2018 08:01AM UTC	0	92.81	Travis Job 4756.1

Source Files on build 4756

Detailed source file information is not available for this build.

se-edu / addressbook-level4 / 4756
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4756

se-edu / addressbook-level4 / 4756 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4756

se-edu / addressbook-level4 / 4756
94%

README BADGES
x