280
72%

Ran 25 Nov 2018 03:11PM UTC

Jobs 1

Files 465

Run time 22s

Badge

Embed ▾

pending completion

Build # 280

Build Type

push

jenkins

Committed by GitHub

Commit Message

Remove MathUtils.now()

Descriptions of the changes in this PR:

*Motivation*

`MathUtils.now()` using System.nanoTime doesn't provide accurate time. It is used
for measuring pupose. However since `nanoTime` can have numeric overflow, so when
it is used for converting into milliseconds, it is misleading and error-prone. A
lot of places using `MathUtis.now` can all replaced with `System.currentTimeMillis()`.

It leads to unknown behavior on compactions. examples is shown in the following figure.

<img width="1157" alt="wechatimg180" src="https://user-images.githubusercontent.com/1217863/48965961-d860b600-ef7c-11e8-9394-1d51cef5c68c.png">

example: this graph shows the major_compaction_count. major compaction is supposed to run every day. but in the graph, there is no major compaction occuring in 4 days.

*Changes*

Remove `MathUtils.now()` and replace it with `System.currentTimeMillis()`.





Reviewers: Jia Zhai <None>, Enrico Olivelli <eolivelli@gmail.com>

This closes #1837 from sijie/remove_mathutils_now

Run Details

25380 of 35164 relevant lines covered (72.18%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	280.1	25 Nov 2018 03:11PM UTC	0	72.18

Source Files on build 280

Detailed source file information is not available for this build.

apache / bookkeeper / 280
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 280

apache / bookkeeper / 280 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 280

apache / bookkeeper / 280
72%

README BADGES
x