277
72%

Ran 22 Nov 2018 02:55PM UTC

Jobs 1

Files 465

Run time 27s

Badge

Embed ▾

pending completion

Build # 277

Build Type

push

jenkins

Committed by GitHub

Commit Message

Fix flake in AuditorPeriodicBookieCheckTest

The flake was occurring because the bookie checker was trying to
connect to a TCP endpoint that didn't respond (1.1.1.1) and was
waiting for the whole tcp connect timeout (10sec), while the test was
waiting 10 seconds for the success condition to occur. The success
condition often occurred just after the test fails.

The solution was to bring the connect timeout for the client down to
500ms, giving the auditor plenty of time to register the
underreplicated ledger.

I guess this used to pass in the past because maybe 1.1.1.1 was
actually rejecting packets instead of dropping them, and these changed
when cloudflare took over the address. I changed the endpoint to
192.0.2.0/24 range (TEST-NET) to avoid a similar scenario in the
future.


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #1826 from ivankelly/auditor-bookie-flake

Run Details

25360 of 35266 relevant lines covered (71.91%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	277.1	22 Nov 2018 02:55PM UTC	0	71.91

Source Files on build 277

Detailed source file information is not available for this build.

apache / bookkeeper / 277
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 277

apache / bookkeeper / 277 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 277

apache / bookkeeper / 277
72%

README BADGES
x