215
98%

Ran 22 Nov 2018 04:17AM UTC

Jobs 2

Files 1

Run time 1min

Badge

Embed ▾

pending completion

Build # 215

Build Type

cron

travis-ci

Committed by

omus

Commit Message

Performance fix: avoid unnecessary `convert` on setindex!、copy when type is same. (#38)

* Add `convert(::Type{T}, x::T) where {T<:FD} = x`

This fixes unnecessary copies on `setindex!`, etc.

* Remove "copy constructor" after correct `convert` fix

The "copy constructor" is no longer necessary now that a no-op
`convert` is added, since by default construction falls back to convert.

To verify, after this change, the performance is still correct:
```
julia> f = FixedPointDecimals.FixedDecimal{Int128,2}(3.25)
FixedDecimal{Int128,2}(3.25)

julia> @btime x = FixedPointDecimals.FixedDecimal{Int128, 2}($f)
  0.036 ns (0 allocations: 0 bytes)
FixedDecimal{Int128,2}(3.25)
```

And `@code_native` shows this to be a simple reinterpret.

Run Details

168 of 170 relevant lines covered (98.82%)

6696.99 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	215.1	22 Nov 2018 04:17AM UTC	0	98.82	Travis Job 215.1
4	215.4	22 Nov 2018 04:19AM UTC	0	98.82	Travis Job 215.4

Source Files on build 215

Detailed source file information is not available for this build.

JuliaMath / FixedPointDecimals.jl / 215
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 215

JuliaMath / FixedPointDecimals.jl / 215 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 215

JuliaMath / FixedPointDecimals.jl / 215
98%

README BADGES
x