• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

TAMULib / Weaver-UI-Core / 115
4%
2.x: 4%

Build:
Build:
LAST BUILD BRANCH: 2.2.7-release
DEFAULT BRANCH: 2.x
Ran 16 Nov 2018 04:47PM UTC
Jobs 1
Files 44
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
115

Pull #134

travis-ci

web-flow
The repo array list should not be directly alterable outside of its scope.

When abstractRepo.getContents() is called, it returns the actual internal array list object.
This exposes the repo array list outside of its internal variable scope.
This allows for unintended changes to the repo array list.

Instead, provide a copy of the array while preserving the original objects.
This prevents the repo array list from being tampered with (intentionally or not).

This fixes issues such as when ngTables adds 'visibleColumnCount' to the repo array list.
When that gets added and abstractRepo.contains(modelJson) is later called, false positives may prevent entries from appearing in the table.
For example, if 'visibleColumnCount' is 4 and some object has an id of 4, that object will never appear because abstractRepo.contains() will claim that '4' already exists in the table.
In this case ngTables is modifying the array list that is passed to it for its own internal designs.
Pull Request #134: The repo array list should not be directly alterable outside of its scope

0 of 598 branches covered (0.0%)

Branch coverage included in aggregate %.

79 of 1474 relevant lines covered (5.36%)

0.05 hits per line

Jobs
ID Job ID Ran Files Coverage
1 115.1 16 Nov 2018 04:47PM UTC 0
3.81
Travis Job 115.1
Source Files on build 115
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Travis Build #115
  • Pull Request #134
  • PR Base - 2.x (#111)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc