TAMULib / Weaver-UI-Core / 115

4%

2.x: 4%

Pull #134

travis-ci

The repo array list should not be directly alterable outside of its scope.

When abstractRepo.getContents() is called, it returns the actual internal array list object.
This exposes the repo array list outside of its internal variable scope.
This allows for unintended changes to the repo array list.

Instead, provide a copy of the array while preserving the original objects.
This prevents the repo array list from being tampered with (intentionally or not).

This fixes issues such as when ngTables adds 'visibleColumnCount' to the repo array list.
When that gets added and abstractRepo.contains(modelJson) is later called, false positives may prevent entries from appearing in the table.
For example, if 'visibleColumnCount' is 4 and some object has an id of 4, that object will never appear because abstractRepo.contains() will claim that '4' already exists in the table.
In this case ngTables is modifying the array list that is passed to it for its own internal designs.

0 of 598 branches covered (0.0%)

Branch coverage included in aggregate %.

79 of 1474 relevant lines covered (5.36%)

0.05 hits per line