xapi-project / sm / 672

34%

master: 47%

Pull #415

travis-ci

CP-29955: Log failures in key lookup plugins

- Previously we did not log anything in the plugin manager when key
  lookup plugins were invoked or when they failed with an exception.  So
  now I have added debug logs to the plugin manager that are written to
  SMlog.
- Fixed how modules in the plugins directory are loaded. To avoid
  loading itself, the plugin manager compared each filename in its
  directory to the __file__ variable. However, sometimes this variable
  was __init__.pyc, not __init__.py, so the comparison returned false,
  and the key manager loaded itself recursively, which in turn tried to
  load the plugins again, but failed.
- I've also removed some pylint warnings: I've converted the Logger
  class into a function, fixed indentation, and removed trailing
  whitespace.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>

832 of 6495 branches covered (12.81%)

260 of 260 new or added lines in 6 files covered. (100.0%)

7086 of 21151 relevant lines covered (33.5%)

0.34 hits per line