optimizely / javascript-sdk / 476
78%

DEFAULT BRANCH: master
Ran
Jobs 6
Files 46
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
476

push

travis-ci

web-flow 
refactor(dist): update bundled files (#189)

## Summary

**BREAKING**: Drop support for `window.optimizelyClient`, as presaged in the [CHANGELOG](https://github.com/optimizely/javascript-sdk/blob/master/packages/optimizely-sdk/CHANGELOG.MD#213---august-21-2018).

- Pull in changes from 2.3.x, to ensure that both optimizely.browser.umd.js and optimizely.browser.umd.min.js are defined.
- Refactor those changes to use webpack config/index.browser code instead of appending to the bundle after-the-fact.
- Actually install `webpack` as a devDependency rather than always using latest

In addition to fixing the issue from #187 in this branch, it simplifies the build script.

## Test plan

Existing unit tests pass since the "node" API for index.browser.js wasn't changed.

Created a test file called "dist/test.html" and loaded it in a browser (as well as an equivalent one that loads the min.js variant):
```html
<!DOCTYPE html>
<html>

<head>
	<script src="/optimizely.browser.umd.js"></script>
</head>

<body>
	<h1>Hello</h1>
	<script>
		console.log('optimizelySdk', typeof optimizelySdk);
		console.log('optimizelyClient', typeof optimizelyClient);
	</script>
</body>

</html>
```
Ensured that it logged "object" for the first, and "undefined" for the second:
![screen shot 2018-11-14 at 3 50 30 pm](https://user-images.githubusercontent.com/1256483/48520564-ecdadb00-e825-11e8-8d97-18c8fe27985c.png)

## Issues
- OASIS-3790

467 of 507 branches covered (92.11%)

Branch coverage included in aggregate %.

4559 of 4657 relevant lines covered (97.9%)

101.29 hits per line

Jobs
ID Job ID Ran Files Coverage
1 476.1 0
97.33
 Travis Job 476.1
2 476.2 0
97.33
 Travis Job 476.2
3 476.3 0
97.33
 Travis Job 476.3
4 476.4 0
97.33
 Travis Job 476.4
5 476.5 0
97.33
 Travis Job 476.5
6 476.6 0
97.33
 Travis Job 476.6
Source Files on build 476
Detailed source file information is not available for this build.