curl / curl / 9254

37%

push

travis-ci

<a href="https://github.com/curl/curl/commit/<a class=hub.com/curl/curl/commit/<a class="double-link" href="https://git"><a class=hub.com/curl/curl/commit/<a class="double-link" href="https://git"><a class=hub.com/curl/curl/commit/<a class="double-link" href="https://git"><a class=hub.com/curl/curl/commit/2f5f31bb57d68b54e03bffcd9648aece1fe564f8">2f5f31bb5<a href="https://github.com/curl/curl/commit/2f5f31bb57d68b54e03bffcd9648aece1fe564f8">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/curl/curl/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/curl/curl/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/curl/curl/commit/2f5f31bb57d68b54e03bffcd9648aece1fe564f8&quot;&gt;2f5f31bb5&lt;/a&gt;&lt;a href=&quot;https://github.com/curl/curl/commit/2f5f31bb57d68b54e03bffcd9648aece1fe564f8&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/curl/curl/commit/2f5f31bb57d68b54e03bffcd9648aece1fe564f8&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;tool_cb_wrt: Silence function cast</a> compiler warning

Commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/curl/curl/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/curl/curl/commit/<a class="double-link" href="https://github.com/curl/curl/commit/5bfaa86ceb3c2a9ac474a928e748c4a86a703b33">5bfaa86ce</a>&quot;&gt;5bfaa86ce&lt;/a&gt;&quot;&gt;5bfaa86ce&lt;/a&gt;&lt;a href=&quot;https://github.com/curl/curl/commit/2f5f31bb57d68b54e03bffcd9648aece1fe564f8&quot;&gt; introduced a new
compiler warning on Windows cross compilation with GCC. See below
for an example of the warning from the autobuild logs (whitespace
edited to fit):

/src/tool_cb_wrt.c:175:9: warning: cast from function call of type
    &amp;#39;intptr_t {aka long long int}&amp;#39; to non-matching type &amp;#39;void *&amp;#39;
    [-Wbad-function-cast]
(HANDLE) _get_osfhandle(fileno(outs-&amp;gt;stream)),
^

Store the return value from _get_osfhandle() in an intermediate
variable and cast the variable in WriteConsoleW() rather than the
function call directly to avoid a compiler warning.

In passing, also add inspection of the MultiByteToWideChar() return
value and return failure in case an error is reported.

Closes #3263
Reviewed-by: Marcel Raad &amp;lt;Marcel.Raa</a>d@teamviewer.com>
Reviewed-by: Viktor Szakats <commit@vszakats.net>

21750 of 29059 relevant lines covered (74.85%)

778919.17 hits per line