IBM / ubiquity / 1495

58%

master: 0%

Pull #263

travis-ci

Fix/ub 1671 idempotent issues in delete (#266)

in this PR the idempotent issues in the delete request are fixed.
the issues are as follows: (in delete volume function)

* in get Back-end in the storage_api_handler delete function - if volume does not exist then return nil.
* in get volume: if volume does not exist then return success
* in vol delete from XIV : if an 404 error is returned from SC then continue with the flow. (to delete from ubiquity DB)
* in delete volume from DB (for the case where we have a non-db volume) if a volume not found error is returned then return success.

in all the above issues an idempotent there is a warning message in the logger.
comment : an assumption is made that if a volume is removed from the DB then it is definitely removed from the storage since the removal from the DB is the latter operation.

Note: addition PR to handle delete idempotent in the flex side -> #266

184 of 184 new or added lines in 9 files covered. (100.0%)

2359 of 4044 relevant lines covered (58.33%)

6.36 hits per line