wemake-services / wemake-python-styleguide / 683

100%

push

travis-ci

Added TooLongVariableNameViolation (#291)

* Issue-288: Changed config.py, defautls.py and naming.py to add TooLongVariableNameViolation rule

Updated CHANGELOG.md

* Removed TooLongVariableNameViolation and added TooLongNameViolation and associated tests

Fixed config MAX_VARIABLE_LENGTH -> MAX_NAME_LENGTH, updated types.py to contain max_name_length

added rule integration into noqa and test_noqa

Fixed documentation (mainly variable -> variable and module)

Forgot extra line at the end of logical.py

Reordered imports to match tests

Fixed line 188 in logical.py

Changed default max-length to 40, changed to tests to reflect this as well

* Changed default max length to 55; some names still violated old limit

ASTViolation -> MaybeASTViolation in naming.py | fixed multi-line string error (added \) in logical.py | other syntax fixes

Removed WrongModuleNamePatternViolation in test_module_name_length.py on line 56 | replaced backslashe line break with indent)

* Changed max-complexity from 6 to 7 to accomodate new if statement in _check_name under naming.py

Removed WrongModuleNamePatternViolation in test_module_name_length.py on line 56 | replaced backslashe line break with indent)

Changed max-complexity from 6 to 7 to accomodate new if statement in _check_name under naming.py

* Left 178 181 and 184 as one line for now in logical.py

Refactored _check_name to include new function _check_name_length; reduces complexity

Erased variable assignment in _check_name instead

Reverted _check_name back to original

* Removed check for long name in naming.py; will be refactored later

Also removed test in test_naming until _check_name is refactored

Removed instances of previous TooLongNameViolation tests in naming.py and test_naming.py

* Removed extra blank line

* Rebased branch and made appropriate changes

Fixed imports

Fixed whitspace issue

Workaround for line limit

a

a

a

a

* Restr... (continued)

616 of 616 branches covered (100.0%)

Branch coverage included in aggregate %.

1600 of 1600 relevant lines covered (100.0%)

2.0 hits per line