5759
60%
master: %

Ran 10 Nov 2018 04:34AM UTC

Jobs 2

Files 85

Run time 3min

Badge

Embed ▾

pending completion

Build # 5759

Build Type

push

travis-ci

Committed by

buger

Commit Message

Fix whitelist/blacklist regex too broad (#1956)

Fixes https://github.com/TykTechnologies/tyk/issues/1944

```
apiLangIDsRegex := regexp.MustCompile(`{([^}]*)}`)
asRegexStr := apiLangIDsRegex.ReplaceAllString(stringSpec, `([^/]*)`)
```

Basically removing logic of detection end of string. And at the same time modifying tests to do that:
```
v.Paths.WhiteList = []string{"/foo/{fooId}$", "/foo/{fooId}/bar/{barId}$"}
```

Basic idea here that here at Tyk we have backward compatibility policy, and this regexp was here for a few years, so there is chance that some of our customers relied on its "confusing" behavior. Thankfuly it was possible to fix it using "$" at the end of string, to explicitly set end of the string. In case of #1944  bug this trick was not working for urls containing {...}. Goal of this PR in this case can be making {...} groups support addign "$" to the end of URL.

Run Details

8599 of 14504 relevant lines covered (59.29%)

1.32 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5759.1 (LATEST_GO=true)	10 Nov 2018 04:34AM UTC	0	59.29	Travis Job 5759.1
2	5759.2 (LATEST_GO=true)	10 Nov 2018 04:37AM UTC	0	59.92	Travis Job 5759.2

Source Files on build 5759

Detailed source file information is not available for this build.

TykTechnologies / tyk / 5759
60%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5759

TykTechnologies / tyk / 5759 60% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5759

TykTechnologies / tyk / 5759
60%
master: %

README BADGES
x