zulip / zulip-mobile / 3719

47%

push

travis-ci

outbox: Keep outbox message after sending, until echo from server.

Our current outbox flow is:
1. Add outbox item and render it
2. Outbox item is sent and removed from outbox
3. New message given back by server and we render

The problem is that at step 2 the message disappears.  On a fast
network this appears as a fast jump in the message list, not ideal
(#2483).  On a slow network this appears as a prolonged and
buggy-looking 'message disappears after sending'.

Now we:
1. Add outbox item and render it.
2. Send but do not remove from list.  Instead mark as `isSent` to
   prevent a duplicate if sending needs to be restarted.
3. New message received, remove from outbox.

Fixes #2483.

1398 of 2930 branches covered (47.71%)

Branch coverage included in aggregate %.

4803 of 6561 relevant lines covered (73.21%)

38.17 hits per line