zulip / zulip-mobile / 7328

47%

push

travis-ci

download: Tweak URL-with-key logic to be a bit more defensive.

It's not entirely obvious whether it's possible for the `src` URL to
already have a query part, in which case we should be using `&` rather
than `?` as the delimiter.  Rather than make and justify an assumption
that that can't happen, borrow the logic we have for handling this in
`appendAuthToImages` in js.js.

There isn't currently an easy way to share the actual code between
these places (one inside the webview, one in the main RN environment),
so that means copying.  Fortunately this is a tiny amount of code and
its logic isn't likely to need to change, so that isn't so bad.

1398 of 2928 branches covered (47.75%)

Branch coverage included in aggregate %.

4802 of 6556 relevant lines covered (73.25%)

38.2 hits per line