nmstate / nmstate / 664

Ran 06 Nov 2018 01:36PM UTC

Jobs 1

Files 23

Run time 3s

Badge

Embed ▾

pending completion

Build # 664

Build Type

push

travis-ci

Committed by

EdDev

Commit Message

Sort the IP addresses in the verification stage of apply().

Issue:
    When having multiple IP addresses, the verification of `netapplier.apply()`
    might fail just because of the order of ip address made by
    NetworkManager.
    For example, user requested IP addresses:
        [192.168.1.1/24, 10.0.0.1/24]
    After applied the setting to NetworkManager, query on NetworkManager
    will return:
        [10.0.0.1/24, 192.168.1.1/24]

Fix:
    * Sort both current IP addresses and desired IP addresses before
      comparison.
    * We are still setting IP addresses in the order of user provides and
      showing IP addresses in the order of NetworkManager returns.
    * Added unit test case and integration test case.

Signed-off-by: Gris Ge <fge@redhat.com>

Coverage Stats

952 of 1315 relevant lines covered (72.4%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	664.1	06 Nov 2018 01:36PM UTC	0	72.4	Travis Job 664.1

Source Files on build 664

Detailed source file information is not available for this build.

nmstate / nmstate / 664

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 664

nmstate / nmstate / 664

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 664

README BADGES
x