nmstate / nmstate / 651

Ran 06 Nov 2018 08:03AM UTC

Jobs 1

Files 22

Run time 2s

Badge

Embed ▾

pending completion

Build # 651

Build Type

push

travis-ci

Committed by

cathay4t

Commit Message

Fix duplex setting when ethtool return unknown.

Issue:
    With virtio-net, libnmstate will failed with error:
        ERROR    NM main-loop aborted: Connection update failed:
        error=nm-connection-error-quark: 802-3-ethernet.duplex:
        'unknown' is not a valid duplex value (7)

Root cause:
    The ethtool return 'unknown' duplex for virtio-net. The 'unknown' is
    illegal value for NetworkManager API.

Fix:
   * Only apply NetworkManager allowed duplex setting: either "half" or
     "full".
   * Hide the 'ethernet' subtree when duplex is not `half` or `full`.
   * Add unit test for invalid ether duplex query.

Signed-off-by: Gris Ge <fge@redhat.com>

Coverage Stats

919 of 1280 relevant lines covered (71.8%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	651.1	06 Nov 2018 08:03AM UTC	0	71.8	Travis Job 651.1

Source Files on build 651

Detailed source file information is not available for this build.

nmstate / nmstate / 651

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 651

nmstate / nmstate / 651

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 651

README BADGES
x