zulip / zulip-mobile / 3706

47%

push

travis-ci

android notif: Fix notifications not working in Android emulator.

Fixes #3113.

The native code inside `react-native-notifications` varied its
behavior when reading the `gcm_id` value from the metadata.  Because
of this, in the emulator it was throwing a `MismatchSenderId` error.

From an upstream issue thread, we take the solution of changing
`android:value="your_sender_id\0"` to `android:value="your_sender_id\"`.
This works on both an emulated and a physical device, despite the
warning in the official documentation:
   // IMPORTANT: Leave the trailing \0 intact!!!

While here, clean up a bit: extract this value to a string resource
and refer to it by name.

1400 of 2939 branches covered (47.64%)

Branch coverage included in aggregate %.

4811 of 6572 relevant lines covered (73.2%)

38.11 hits per line