ckeditor / ckeditor5-engine / 4066

100%

push

travis-ci

Merge pull request #1574 from ckeditor/t/1554

Feature: The `model.insertContent()` method will accept offset parameter. Made `Position.createAt()` require the `offset` when the first parameter is an model/view item. See breaking changes. Closes #1554.

BREAKING CHANGE: The `offset` parameter of the following methods does not default to `0` and hence is no longer optional when `itemOrPosition` is a model/view item:

* `model.Position.createAt()`
* `model.Range.createCollapsedAt()`
* `model.Selection#setFocus()`
* `model.Writer#insert()`
* `model.Writer#insertText()`
* `model.Writer#insertElement()`
* `model.Writer#move()`
* `model.Writer#setSelectionFocus()`
* `view.Writer#setSelectionFocus()`
* `view.Position.createAt()`
* `view.Range.createCollapsedAt()`
* `view.Selection#setFocus()`

4659 of 4659 branches covered (100.0%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 14 files covered. (100.0%)

7629 of 7629 relevant lines covered (100.0%)

11031.54 hits per line