56
92%
master: 91%

Ran 26 Oct 2018 03:00PM UTC

Jobs 1

Files 10

Run time 1s

Badge

Embed ▾

pending completion

Build # 56

Build Type

push

travis-ci

Committed by

thraxil

Commit Message

fix subprocess pipe hanging issue

Just calling `.wait()` without reading stdout can result in the
process deadlocking when the pipe fills up.

We could call `.communicate()`, which ensures that it all gets read,
but has its own risk of memory filling up because it buffers it all:
https://docs.python.org/2/library/subprocess.html#subprocess.Popen.communicate

Instead, we just loop over it, reading line by line until it hits a
`StopIteration`.

I do not have a unit test for this bug, unfortunately. It's a tricky
interaction between python and the system that it's running on and
would likely be a flakey test at best. Furthermore, reproducing the
bug and successfully testing for it would involve detecting that the
program had hung, and that gets tricky (halting problem and all).

Run Details

148 of 161 relevant lines covered (91.93%)

0.92 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	56.1	26 Oct 2018 03:00PM UTC	0	91.93	Travis Job 56.1

Source Files on build 56

Detailed source file information is not available for this build.

appsembler / tahoe_cert_agent / 56
92%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 56

appsembler / tahoe_cert_agent / 56 92% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 56

appsembler / tahoe_cert_agent / 56
92%
master: 91%

README BADGES
x