apache / commons-pool / 215

85%

trunk: 85%

Pull #11

travis-ci

POOL-356 fix deadlock on massive concurrent requests

Happens when blockWhenExhausted is active.
The idleObjects.takeFirst and .pollFirst operations perform a lock.
So if the pool is empty and the MaxTotal is hit we end up having multiple
Threads perform a lock internally via idleObjects.takeFirst().

But if a condition occurs to destroy the object instead of putting it back into the pool
then nobody notifies the Lock Condition.

The proposed solution will simply create a new object in that case and puts
it back into the idle queue IF there are active threads waiting for
some idle objects.

3 of 3 new or added lines in 1 file covered. (100.0%)

2522 of 2961 relevant lines covered (85.17%)

329995.25 hits per line