go-kit / kit / 2203

51%

push

travis-ci

Fix 'Client.Endpoint' to not 'cancel' when bufferedStream (#776)

* transport/http/client_test: Modify the test to make it fail

With this modifications we can trigger the error that we are searching, 'context canceled'

* transport/http/client: Add the 'bodyWithCancel' to wrap the Response.Body

It adds the context.CancelFunc to the io.ReadCloser.Close function so bouth are called together

* transport/http/client: Add more documentation to clarify the changes

Also abstracted some logic on the test to make it more clear and also added more docuemntation. Added more documentation
on the definition of 'BufferedStream' to clarify that the Body has to be closed manually to properly close the response.

* transport/http/client: Add period at the end of the doc of 'BufferedStream'

12 of 12 new or added lines in 1 file covered. (100.0%)

5293 of 6667 relevant lines covered (79.39%)

147435.49 hits per line