AugurProject / augur-ui / 2110

100%

push

travis-ci-com

johndanz/ch15995/full-site-prop-validation-review (#2397)

* walked through app, auth, account

* worked on props for categories

* replaced string concat with template string in transactions, removed unused files in common, added default props to simple-button.jsx

* adjusted props for create-markets components and moved a continer to market-charts

* fixed some key props strings, added some proptypes to makret liquidity

* cleaned up some unused props in forking

* added proptypes to market components, except positions lists.

* more prop clarifications, finished market

* reviewed props in marketss-list and removed a prop in transaction-meta

* passed through modal and notification props, did some minor refactoring to some of the modals and notification view to remove annoying need to do props.notifications.notifications

* completely removed order-book folder as it was unused was missed in the cleanup/restructure

* started working through props for portfolio

* prop walkthrough for portfolio section

* updated custom bignumber proptypes to allow for isRequired, working through reporting components for prop validation

* started working through making sure all props are needed using eslint rule i forgot to turn back on

* walked through all props to make sure none are unused.

* added defaultProps to everything.

* adjusted some things based on pr feedback

* fixed issue with failing testt

* added currentBasePath to the baseInnerNav propTypes

* prop should be string not number

* fix chevons showing up

1385 of 3107 branches covered (44.58%)

Branch coverage included in aggregate %.

3377 of 5327 relevant lines covered (63.39%)

23.18 hits per line