1889
92%

Ran 18 Oct 2018 12:23PM UTC

Jobs 1

Files 39

Run time 3s

Badge

Embed ▾

pending completion

Build # 1889

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[NFC] BenchmarkRunner: always populate *_report_aggregates_only bools. (#708)

It is better to let the RunBenchmarks(), report() decide
whether to actually *only* output aggregates or not,
depending on whether there are actually aggregates.

It's subtle indeed.

Previously, `BenchmarkRunner()` always said that "if there are no repetitions,
then you should never output only the repetitions". And the `report()` simply assumed
that the `report_aggregates_only` bool it received makes sense, and simply used it.

Now, the logic is the same, but the blame has shifted.
`BenchmarkRunner()` always propagates what those benchmarks would have wanted
to happen wrt the aggregates. And the `report()` lambda has to actually consider
both the `report_aggregates_only` bool, and it's meaningfulness.

To put it in the context of the patch series - if the repetition count was `1`,
but `*_report_aggregates_only` was set to `true`, and we capture each iteration separately,
then we will compute the aggregates, but then output everything, both the iteration,
and aggregates, despite `*_report_aggregates_only` being set to `true`.

Run Details

1595 of 1788 relevant lines covered (89.21%)

5049025.34 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1889.1 (COMPILER=g++ C_COMPILER=gcc BUILD_TYPE=Coverage)	18 Oct 2018 12:23PM UTC	39	89.21	Travis Job 1889.1

google / benchmark / 1889
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1889

google / benchmark / 1889 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1889

google / benchmark / 1889
92%

README BADGES
x