theforeman / foreman / 11523

68%

push

travis-ci

Fixes #25203 - show hosts count if hostsCount is not null

ngettext expects the last argument to be a number.
factCharts.hostsCount is initialized to null in Redux.

when rendering the factChart modal the number of hosts is
translated using ngettext.

However, if factChart is rendered before the data arrives
the component will fail printing the error below in the console:

"The number that was passed in is not a number"

To fix this if factCharts.hostsCount is null don't display
hosts count in the title.

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

547 of 854 branches covered (64.05%)

1379 of 1826 relevant lines covered (75.52%)

97.15 hits per line