8966
37%

Ran 16 Oct 2018 09:59AM UTC

Jobs 1

Files 275

Run time 849min

Badge

Embed ▾

pending completion

Build # 8966

Build Type

push

travis-ci

Committed by Jay Satiro

Commit Message

x509asn1: Fix SAN IP address verification

For IP addresses in the subject alternative name field, the length
of the IP address (and hence the number of bytes to perform a
memcmp on) is incorrectly calculated to be zero. The code previously
subtracted q from name.end. where in a successful case q = name.end
and therefore addrlen equalled 0. The change modifies the code to
subtract name.beg from name.end to calculate the length correctly.

The issue only affects libcurl with GSKit SSL, not other SSL backends.
The issue is not a security issue as IP verification would always fail.

Fixes #3102
Closes #3141

Run Details

21312 of 28983 relevant lines covered (73.53%)

620119.86 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	95.12	-0.81%	lib/curl_ntlm_core.c
1	81.06	-0.25%	lib/vauth/digest.c
1	80.93	-0.52%	lib/vauth/ntlm.c
3	73.82	-1.57%	lib/curl_addrinfo.c

Jobs

ID	Job ID	Ran	Files	Coverage
22	8966.22 (T=coverage)	16 Oct 2018 09:59AM UTC	275	73.53	Travis Job 8966.22

curl / curl / 8966
37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8966

curl / curl / 8966 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8966

curl / curl / 8966
37%

README BADGES
x