• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

rodolfobandeira / spacex / 92
100%

Build:
DEFAULT BRANCH: master
Ran 16 Oct 2018 02:23AM UTC
Jobs 1
Files 21
Run time 1280min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
92

push

travis-ci

rodolfobandeira
More refactoring (#41)

While working on implementing the history endpoint, I realized that
passing querystring params to the endpoints is going to require some
refactoring for the base_request class.

As I started getting deeper into that class, I realized that the
`call_api` method is not really required as the `get` method is already
doing the necessary `if else` check.

I ended up cleaning a lot more than I initially anticipated but this
refactor feels like a step in the right direction and makes the codebase
more consistent

While running the tests locally, I had to rerecord the cassettes as the
get method adds an extra slash at the end of the URLs when the id passed
is nil.

As a result, I had to modify a couple of specs as elon's roadster has
moved further in its journey.

57 of 57 new or added lines in 12 files covered. (100.0%)

751 of 751 relevant lines covered (100.0%)

3.82 hits per line

Jobs
ID Job ID Ran Files Coverage
1 92.1 (2.4.1) 16 Oct 2018 02:23AM UTC 0
100.0
Travis Job 92.1
Source Files on build 92
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #92
  • ae7127fb on github
  • Prev Build on master (#90)
  • Next Build on master (#93)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc