• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jknowles / eeptools / 84
83%
master: 83%

Build:
Build:
LAST BUILD BRANCH: fix-logical-check-warning
DEFAULT BRANCH: master
Ran 14 Oct 2018 12:34AM UTC
Jobs 3
Files 21
Run time 30s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
84

Pull #39

travis-ci

web-flow
Some awesome title

Why:

* In `max_mis`, there is an `if` predicate that checks if a class is of an invalid type. Because R objects can have multiple classes, this statement relies on the R semantics that the first value of the logical vector returned by the predicate is used. This is a feature R-core is looking to remove as it has considerable performance penalties. See https://developer.r-project.org/Blog/public/2018/10/12/conditions-of-length-greater-than-one/index.html for the discussion of testing for this behavior change and the following report showing `eeptools` failing a why: https://github.com/kalibera/rifcond/blob/master/outputs/eeptools.Rcheck/tests/test-all.Rout.fail

This change addresses the need by:

* This check is now wrapped in `any()`, which evaluates `TRUE` if any value in the logical vector is `TRUE`.
Pull Request #39: Removes vector response from if predicate to help R-core move this to an error condition

1 of 1 new or added line in 1 file covered. (100.0%)

374 of 474 relevant lines covered (78.9%)

22.03 hits per line

Jobs
ID Job ID Ran Files Coverage
1 84.1 (NOT_CRAN="true") 14 Oct 2018 12:34AM UTC 0
78.9
Travis Job 84.1
2 84.2 (NOT_CRAN="false") 14 Oct 2018 12:34AM UTC 0
78.9
Travis Job 84.2
4 84.4 (NOT_CRAN="false") 14 Oct 2018 12:34AM UTC 0
78.9
Travis Job 84.4
Source Files on build 84
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #84
  • Pull Request #39
  • PR Base - master (#83)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc