pvlib / pvlib-python / 1639
96%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 39
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1639

push

travis-ci

wholmgren 
ENH: geometric calculations for sunrise, sunset, and transit (#583)

* add analytical methods from Frank Vignola's book for sunrise, sunset, and sun transit times

* ENH: remove test data file for sunrise/sunset/transit

* use hardcoded values for 10-20 expected values
* remove DIRNAME, etc
* make stickler happy
* no rst markup in numpydoc parameters
* add references to duffie/beckman and Frank Vignola
* get pytz timezone info first so it's not weird
* add returns to docstring

* ENH: PERF: use numpy instead of loop to improve performance

* add one-liners to explain helpers
* remove import os from test

* ENH: use ducktyping to handle different versions of pandas

* if old pandas change tz directly, and hours is already a numpy array
* if new pandas then use tz_localize to strip tz, and change hours from
Float64Index to numpy array
* move operator to end to match existing style in pvlib

* ducktype hours if Float64index or not, convert datetime64[D] to ns before adding

* ENH: use "geometric" instead of "analytical"

* change name in solarposition.py and test_solarposition.py
* enforce that hours is a numpy array in _hours instead of in _times
* add more useful comments, separate into steps to explain process

* ENH: use more verbose, meaningful names for helpers _hours and _times

* change _hours to _hour_angle_to_hours
* change _times to _local_times_from_hours_since_midnite
* fix typos in warning circular orbit
* fix reference numbers
* clarify sign conventions for latitude and longitude

* remove EXPECTED_ANALYTICAL_SUNRISE_SUNSET_TRANSIT

* instead use a test pytest.fixture with a few dates like the ephem and
spa.c test

* stickler - missing whitespace after comma in list

* use np.asarray to ensure consistent return

* remove try-except, doesn't work anyway, wait for pandas >=0.15.0

* also remove utcoffset(), unreliable with pandas dataframes, only really
works with scalar datetimes and times... (continued)

6249 of 6694 relevant lines covered (93.35%)

4.61 hits per line

Jobs
ID Job ID Ran Files Coverage
2 1639.2 (CONDA_ENV=py27) 0
93.23
 Travis Job 1639.2
3 1639.3 (CONDA_ENV=py34) 0
93.13
 Travis Job 1639.3
4 1639.4 (CONDA_ENV=py35) 0
93.14
 Travis Job 1639.4
5 1639.5 (CONDA_ENV=py36 TASK="coverage" DEPLOY_ENV="true") 0
93.14
 Travis Job 1639.5
6 1639.6 (CONDA_ENV=py37) 0
88.8
 Travis Job 1639.6
Source Files on build 1639
Detailed source file information is not available for this build.