CS2113-AY1819S1-T13-1 / main / 55

69%

push

travis-ci-com

[v1.2] Backup Feature (#39)

* Model: Add backup property to UserPrefs model

Add backup file path to user preferences model.

Modified equals to compare backup location

Modified string builder to include backup path

* [Tests] Update JsonUserPrefsStorageTest

Modify ExtraValues json test file
Add `addressBookBackupFilePath` to typical user prefs json test file

* [Model] Add UserPrefs to Model

[Model]
UserPrefs is required to be in model manager as commands run can affect user preferences which should be part of model.

Refer to original AB4 architecture diagram

Added getUserPref method to Model interface

Fix UserPref model returning wrong path in getAddressBookBackupFilePath

[Tests]
Fix Stubbed ModelManager in AddCommandTest

* Add backup methods to AddressBookStorage

Make AddressBookStorage and XmlAddressBookStorage have the required backup methods

* Remove UserPrefs comparison from ModelManager

As long as AddressBook data are equal, userprefs can be different which is okay

* Additional tests for XmlAddressBookStorage

* Add basic backup command

Backup Command currently calls model.backupAddressBook, perhaps we should raise a backup request event from command direct and get handled by storage manager directly as we do not need to modify the model

* Add sample tests for backup command

* CheckStyle Fixes

* More CheckStyle Fixes

* More checkstyle fixes :(

* Make backup generic to allow future extensions

More tests
Bug Fixes

* Resolve conflicts

* Checkstyle fixes

* Add tests to fix coverage

* Fix BackupCommandParser tests

* Fixs bugs

* Last try to fix test on linux

* Remove test

Impossible to make exception to be thrown on linux even with mocking for invalid paths

* Remove unused imports

27 of 27 new or added lines in 6 files covered. (100.0%)

1468 of 1593 relevant lines covered (92.15%)

0.92 hits per line