uPortal-Project / uportal-app-framework / 3725

40%

push

travis-ci

fix(messages): make goLiveDate, expireDate, and audienceFilter.groups optional (#846)

* fix(messages): make goLiveDate and expireDate each optional

These were already documented as optional. This fix makes them optional in practice.

* fix(messages): log the error when fail to get messages

"Problem getting ..." raised the question *what problem?*. Logging the error itself helps answer.

* fix(messages): support omitting audienceFilter.groups outright.

* feat(logging): log when exclude message because invalid date

* feat(examples): Clarify and extend sample-messages.json to demo more

Demonstrate optionalness of fields and filtering messages based on goLiveDate and expireDate

* feat(logging): log message.id when error retrieving data for notification

* feat(logging): log the error when there's a problem getting groups

"Problem getting groups..." suggests the question, what was the problem? This answers the question.

* docs(messages): clarify audienceFilter.groups

124 of 767 branches covered (16.17%)

818 of 2116 relevant lines covered (38.66%)

57.81 hits per line