danielberkompas / cloak / 224

99%

master: 99%

Pull #82

travis-ci

Migration task succeeds on empty table

This functionality appears to have been introduced in
cdeae97c6; however, it looks like it was
removed as part of the refactor to use a cursor for IDs rather than
requiring numeric IDs in 01946dcd3.

With this change, if the migrator is passed a schema that is linked to
an empty table, an error is no longer raised. Instead, the migration is
not attempted, and the function returns that the migration completed.

This does have the impact of changing the return value of the function
in this scenario. Rather than the `:ok` it otherwise returns, instead
it returns a tuple `{:ok, message}`, where the message includes
information about why no migration took place. It doesn't appear that
the return value of this function is used; however, this technically
breaks the public API in the scenario where the schema has no data.

While that tuple is not surfaced to the end-user as part of this effort,
it has the impact of making testing this change easier by making the
impact observable for something that would have no side-effect
(given that the migration does nothing, as there's no data to migrate).
Presumably this could be helpful to callers as well.

2 of 2 new or added lines in 1 file covered. (100.0%)

160 of 162 relevant lines covered (98.77%)

740.75 hits per line