18034
56%

Ran 02 Oct 2018 10:14AM UTC

Jobs 3

Files 937

Run time 2min

Badge

Embed ▾

pending completion

Build # 18034

Build Type

push

travis-ci

Committed by

rmehta

Commit Message

Pass Werkzeug/WSGI middleware bytestrings, not unicode. (#6180)

* Pass Werkzeug/WSGI middleware bytestrings, not unicode.

This fixes a bug that prevents website routing to non-ascii routes, such as
will be automatically created by items with non-ascii characters in their
names.

Werkzeug/WSGI actually does careful decoding of URLs passed to it which
ensure they are in the correct format internally. However, using a non-ascii
URL was causing a unicode error and exceptions.

In app.py, unicode_literals is in effect. SharedDataMiddleware and
StaticDataMiddleware instances are created to deal with files in 'assets'
and 'files', respectively. The paths passed need to be bytestrings; however,
due to the use of unicode, these were passed as unicode. This was causing a
later exception when using a (unicode) string method on the decoded URL
string. By explicitly passing bytestrings, this is avoided and everything
works as expected.

* Instead of calling str, call .encode('ascii') method for compatibility with Python3.

* Unicode URL WSGI fix: After testing, it is actually the key not the value of
the export that matters, however both can be wrapped in str() to get 'bytes'
in Python 2 and unicode in Python 3 (which WSGI seems to expect).

Run Details

17569 of 38651 relevant lines covered (45.46%)

1.35 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	18034.1 (DB=mariadb)	02 Oct 2018 10:14AM UTC	44.99	Travis Job 18034.1
2	18034.2 (DB=mariadb)	02 Oct 2018 10:16AM UTC	45.01	Travis Job 18034.2
3	18034.3 (DB=postgres)	02 Oct 2018 10:16AM UTC	45.02	Travis Job 18034.3

Source Files on build 18034

Detailed source file information is not available for this build.

frappe / frappe / 18034
56%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 18034

frappe / frappe / 18034 56%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 18034

frappe / frappe / 18034
56%

README BADGES
x