sqitchers / sqitch / 138

91%

develop: 100%

push

travis-ci-com

Make username and password proper engine attributes.

This lets us formalize the proper search order for these attributes. The order
is:

1.  The `$SQITCH_USERNAME` and `$SQITCH_PASSWORD` environment variables.
2.  The username and password from the target URI.
3.  Engine-specific defaults.

The third option is covered by the new `_def_user()` and `_def_pass()`
methods. Subclasses may implement them to return whatever values they deem
appropriate. Each engine requiring authentication has added these methods,
sometimes returning no value at all, other times searching engine-specific
environment variables, configruation files, or the system.

This change was driven by the need to be explicit about username, in
particular, when a database engine falls back on the system user. Rather than
let the underlying engines implicitly read these values, we implicitly collect
them. And because we have the `$SQITCH_ORIG_SYSUSER` environment variable,
that means we properly use it for all connections. In other words, when using
the Sqitch Docker image to deploy to postgres, all conections will use the
originating host username rather than the image username.

This change reverses 22d9d51, returning to the pattern of letting each engine
control its default values, rather than falling back on the system user for
all of them (and ignoring engine-specific environment variables).

While at it, fix the vertica environment variable tests, which had been using
the wrong environment variable names.

12 of 12 new or added lines in 5 files covered. (100.0%)

4240 of 4537 relevant lines covered (93.45%)

61.1 hits per line