torchbox / wagtail / 2629

38%

master: 96%

Build Type

push

travis-ci

Committed by Matt Westcott

Commit Message

Avoid placing Block instances into a set(), as this requires them to be hashable.

Defining Block.__eq__ in 047ff734c causes the default __hash__ implementation to be nullified on Python 3. Since it's non-trivial to define a replacement __hash__ method that's consistent with our __eq__ behaviour (it depends on the equality of lists / dicts, which are themselves unhashable), it's more correct to explicitly define Block as unhashable, bringing the Python 2 behaviour in line with Python 3.

The one place where we currently depend on Block being hashable is in constructing the 'dependencies' set for nested blocks. Since we don't actually need the de-duplicating behaviour of set(), we can replace this with a plain list with no ill effects.

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

12526 of 13483 relevant lines covered (92.9%)

4.64 hits per line