1462
92%

Ran 12 Feb 2015 07:34PM UTC

Jobs 13

Files 363

Run time 18min

Badge

Embed ▾

pending completion

Build # 1462

Build Type

Pull #1333

travis-ci

Committed by

carlsverre

Commit Message

Coroutine exception __context__ leak in python 3

In Python 3 every exception has an auto-attached __context__ exception if it was
raised while an existing exception was being handled.  This is often a very
useful property and allows users to see the underlying cause of many problems.

However, when dealing with async code via coroutines this feature can suddenly
become a pretty big issue.  Namely, if you generator.throw back into a coroutine
to raise an exception in the correct scope, and that coroutine raises an
exception at a later time you can have nested exceptions which shouldn't
logically be nested.

This patch resolves this issue in the coroutine code by moving the gen.throw
outside of the exception handler.  By doing this the user-code scope is able to
later raise exceptions without worrying about inheriting prior exception
context.

Pull Request Pull Request #1333: Coroutine exception __context__ leak in python 3

Run Details

71439 of 84207 relevant lines covered (84.84%)

1.52 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	/home/travis/virtualenv/python3.3.5/lib/python3.3/site-packages/tornado-4.2.dev1-py3.3-linux-x86_64.egg/tornado/gen.py
1	100.0	/home/travis/virtualenv/pypy3-2.4.0/site-packages/tornado-4.2.dev1-py3.2.egg/tornado/gen.py
4	100.0	/home/travis/virtualenv/python3.3.5/lib/python3.3/site-packages/tornado-4.2.dev1-py3.3-linux-x86_64.egg/tornado/test/gen_test.py
4	100.0	/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/tornado-4.2.dev1-py3.4-linux-x86_64.egg/tornado/test/gen_test.py
19	100.0	/home/travis/virtualenv/python3.2.5/lib/python3.2/site-packages/tornado-4.2.dev1-py3.2-linux-x86_64.egg/tornado/test/gen_test.py
19	100.0	/home/travis/virtualenv/pypy3-2.4.0/site-packages/tornado-4.2.dev1-py3.2.egg/tornado/test/gen_test.py
19	100.0	/home/travis/virtualenv/pypy-2.5.0/site-packages/tornado-4.2.dev1-py2.7.egg/tornado/test/gen_test.py

Jobs

ID	Job ID	Ran	Coverage
1	1462.1 (DEPS=true)	12 Feb 2015 07:36PM UTC		Travis Job 1462.1
2	1462.2 (DEPS=false)	12 Feb 2015 07:34PM UTC		Travis Job 1462.2
3	1462.3 (DEPS=true)	12 Feb 2015 07:37PM UTC		Travis Job 1462.3
5	1462.5 (DEPS=true)	12 Feb 2015 07:40PM UTC	83.26	Travis Job 1462.5
6	1462.6 (DEPS=false)	12 Feb 2015 07:41PM UTC	82.99	Travis Job 1462.6
7	1462.7 (DEPS=true)	12 Feb 2015 07:37PM UTC	85.4	Travis Job 1462.7
8	1462.8 (DEPS=false)	12 Feb 2015 07:38PM UTC	83.67	Travis Job 1462.8
9	1462.9 (DEPS=true)	12 Feb 2015 07:42PM UTC	87.75	Travis Job 1462.9
10	1462.10 (DEPS=false)	12 Feb 2015 07:41PM UTC	83.71	Travis Job 1462.10
11	1462.11 (DEPS=true)	12 Feb 2015 07:46PM UTC		Travis Job 1462.11
12	1462.12 (DEPS=false)	12 Feb 2015 07:44PM UTC	83.96	Travis Job 1462.12
13	1462.13 (DEPS=true)	12 Feb 2015 07:53PM UTC	83.63	Travis Job 1462.13
14	1462.14 (DEPS=false)	12 Feb 2015 07:51PM UTC	83.63	Travis Job 1462.14

Source Files on build 1462

Detailed source file information is not available for this build.

tornadoweb / tornado / 1462
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1462

tornadoweb / tornado / 1462 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1462

tornadoweb / tornado / 1462
92%

README BADGES
x