trinker / sentimentr / 298

19%

Build Type

push

travis-ci

Committed by Tyler Rinker

Commit Message

BUG FIXES

* In `sentiment` when there was a larger de-amplifier, negator, & polarized word
  all in the same chunk the sentiment would equal 0.  This occurred because the
  de-amplifier weights below -1 are capped at -1 lower bound.  To compute the
  weight for de-amplifiers this was added with 1 and then multiplied by the
  polity score.  Adding 1 and -1 resulted in 0 * polarity = 0.  This was spotted
  thanks to Ashley Wysocki (see #80).  In the case Ashley's example was with an
  adversative conjunction which is treated as an extreme amplifier, which when
  combined with a negator, is treated as a de-amplifier.  This resulted in a -1
  De-amplifier score.  De-amplifiers are now capped at -.999 rather than -1 to
  avoid this. close #80

* Chunks containing adversative conjunctions are supposed to act in the following
  way: "An adversative conjunction before the polarized word...up-weights the
  cluster...An adversative conjunction after the polarized word down-weights the
  cluster...".  This was up-weighting the first as well.  A comma stop has been
  used to block the first clause from being up-weighted but is not yet
  down-weighted per the documentation.  Either a true fix will be seen in the next
  version or the documentation will be corrected to address this issue. See #85.

CHANGES

* `highlight` now writes the .html file to the temp directory rather than the
  working directory by default.

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

297 of 696 relevant lines covered (42.67%)

151.31 hits per line