helpscout / react-utils / 23

100%

push

travis-ci

getValidProps: Improve filtering (#5)

This update improve the prop filtering for `getValidProps` and `isPropValid`.
It uses the REGEX based algorithm borrowed from `styled-components`.

Previously, this function was using the `is-prop-valid` util from `Emotion`.
It worked, for the most part. However, it did not filter out custom props that
were named similarly to default React props, mainly things beginning with `on`.

Props like `onOpen` or `onDidClose` would be let through.

68 of 68 branches covered (100.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

60 of 60 relevant lines covered (100.0%)

18.15 hits per line