tinesoft / ng-scrollreveal / 295

94%

push

travis-ci

feat(core): migrate to ScrollReveal `v4.x.x`

- add `desktop` option in `NgsRevealConfig`
- add `beforeReveal$`, `afterReveal$`, `beforeReset$`, `afterReset$` observables in `NgsRevealService` to subscribe to these events (see usage [here](https://github.com/tinesoft/ng-scrollreveal#subscribing-to-scrollreveal-events))

BREAKING CHANGE: Here are the breaking changes, mostly coming from ScrollReveal:

- `@types/scrollreveal` is no longer necessary and **must be removed** from your `package.son`
- `options.distance` now only supports `em`, `px` and `%` values
- `NgsRevealConfig` default values have been updated to match [ScrollReveal](https://scrollrevealjs.org/api/defaults.html)'s
- be aware that `ScrollReveal` now requires a **commercial license**, unless for [GPL-3.0](https://opensource.org/licenses/GPL-3.0) compatible open source projects.

28 of 41 branches covered (68.29%)

34 of 34 new or added lines in 2 files covered. (100.0%)

120 of 126 relevant lines covered (95.24%)

5.6 hits per line