ReactiveX / rxjs / 7173

97%

push

travis-ci

fix(subscribe): report errors that occur in subscribe after the initial error (#4089)

* chore(reportError): implement reportError

* fix(subscribe): don't swallow internal errors

Closes #3803

* chore(reportError): remove console.log from test

* chore(reportError): test destination is Subscriber

* test(reportError): use closed observer

* chore(reportError): test subscriber symbol too

* chore(reportError): fix logic

* chore(reportError): rename to consoleWarn

* test(reportError): stub the console

* chore(reportError): fix whitespace

* refactor(reportError): use canReportError instead

* refactor(canReport): remove recursion

* test(subscribe): test internal error reporting

* test(bindCallback): test error reporting

* test(bindNodeCallback): test error reporting

* chore(canReport): fix JSDoc

* chore(test): fix test description

* test(canReport): use noop error handlers

* chore(canReport): use isTrustedSubscriber

* chore(canReport): restrict observer type

* chore(canReport): fix tests

* chore(canReport): use console.warn directly

1809 of 2177 branches covered (83.1%)

23 of 23 new or added lines in 5 files covered. (100.0%)

5762 of 5942 relevant lines covered (96.97%)

1054.0 hits per line