broadinstitute / sam / 2051

78%

push

travis-ci

Managed Group Access Instructions (#199)

* change endpoints and service to support access instructions in sam and only notify admins of access requests if instructions are not set; reading and writing of access instructions stubbed out

* add AdminGroupRoutes for setting access instructions; implement reading and writing of access instructions to ldap

* write tests for managed group access instructions

* remove unused test

* update swagger docs and add v1 routes tests

* remove unused import

* change endpoints to remove admin endpoint and have more straightforward get/set of access instructions

* replace admin endpoint with standard one; create get access instructions endpoint; change request access to return 400 if access instructions are set; add tests to improve coverage

* remove duplication in LdapDirectoryDAO; change post to put; remove groupName from accessInstructions payload

* update test name

* make changes according to pr comments from qi and dvoet

52 of 52 new or added lines in 5 files covered. (100.0%)

1261 of 1768 relevant lines covered (71.32%)

0.71 hits per line