1209
32%

Ran 10 Sep 2018 11:29AM UTC

Jobs 1

Files 53

Run time 5s

Badge

Embed ▾

pending completion

Build # 1209

Build Type

cron

travis-ci

Committed by

Geal

Commit Message

Do not forget to clear the backend token when returning ReconnectBackend

This caused an annoying bug:

- when handling ReconnectBackend, the event loop will remove from the
slab the client entry corresponding to the backend token
- the backend token could then be reused as frontend token for
another session
- then the first session is closed. In the event loop's close_client
method, we call cthe close() method on the client structure, which will
return its frontend token (still valid) and its backend token (which has
been given to another session)
- close_client will then remove all of the slab entries corresponding to
these tokens, and then removing the second session

This bug was detectable because some metrics are updated when we close a
session:
- client.connections is decremented in close_client()
- backend.connections, http.active_requests, protocol.proxy.expect,
protocol.tls.handshake, protocol.https, protocol.wss are decremented in
the session's close() method
- since the session was deleted without calling close_client, those
metrics would appear to increase indefinitely

Run Details

5352 of 13430 relevant lines covered (39.85%)

0.45 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	1209.4	10 Sep 2018 11:29AM UTC	0	39.85	Travis Job 1209.4

Source Files on build 1209

Detailed source file information is not available for this build.

sozu-proxy / sozu / 1209
32%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1209

sozu-proxy / sozu / 1209 32%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1209

sozu-proxy / sozu / 1209
32%

README BADGES
x